Re: [PATCH] ACPI: PCI: Fix device reference counting in acpi_get_pci_dev()

[Bjorn Helgaas]

On Wed, Oct 19, 2022 at 11:54:42AM +0300, Ville Syrjälä wrote:
> On Tue, Oct 18, 2022 at 07:34:03PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > 
> > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") failed
> > to reference count the device returned by acpi_get_pci_dev() as
> > expected by its callers which in some cases may cause device objects
> > to be dropped prematurely.
> > 
> > Add the missing get_device() to acpi_get_pci_dev().
> > 
> > Fixes: 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> 
> FYI this (and the rtc-cmos regression discussed in
> https://lore.kernel.org/linux-acpi/5887691.lOV4Wx5bFT@kreacher/)
> took down the entire Intel gfx CI.

>From 1000 miles away and zero background with the gfx CI, this sounds
like "our CI system, whose purpose is to find bugs, found one", which
is a good thing.

Bjorn