Re: [PATCH] null_blk: allow teardown on request timeout

From: Bart Van Assche
Date: Wed Oct 19 2022 - 13:41:28 EST


On 10/18/22 21:19, Chaitanya Kulkarni wrote:
Also, I've listed the problem that I've seen first hand for keeping the
device in the system that is non-responsive due to request timeouts, in
that case we should let user decide whether user wants to remove or keep
the device in the system instead of forcing user to keep the device in
the system bringing down whole system, and these problems are really
hard to debug even with Teledyne LeCroy [1]. This patch follows the same
philosophy where user can decide to opt in for removal with module
parameter. Once opt-in user knows what he is getting into.

Hi Chaitanya,

From commit f2298c0403b0 ("null_blk: multi queue aware block test driver"): "Written to facilitate testing of the blk-mq code". I'm not sure of this but adding a mechanism like the one in this patch may fall outside the original scope of the null_blk driver.

Thanks,

Bart.