Re: [PATCH 2/5] x86/microcode: Simplify init path even more

From: Borislav Petkov
Date: Wed Oct 19 2022 - 15:38:22 EST


On Wed, Oct 19, 2022 at 12:22:57PM -0700, Ashok Raj wrote:
> Good cleanup overall!.. Trying to apply them and do a quick test.

Thx. Use 6.1-rc1 as base.

> You need to call a microcode_ops->apply_microcode() too if you want to
> apply.

That's done ...

> But you also want to pay attention to the return code too and call it
> appropriately.

Ah ok, yes, I need to check ->request_microcode_fw's retval.

> > /* Do per-CPU setup */
> > cpus_read_lock();
> > on_each_cpu(setup_online_cpu, NULL, 0);

... in here.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette