Re: [ammarfaizi2-block:akpm/mm/mm-unstable 39/119] mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init'

[Andrew Morton]

On Wed, 19 Oct 2022 17:17:36 +0800 kernel test robot <lkp@xxxxxxxxx> wrote:

> >> mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init' [-Wmissing-prototypes]
>      521 | void zone_device_page_init(struct page *page)
>          |      ^~~~~~~~~~~~~~~~~~~~~

huh, sorry, I must have fat-fingered the reject resolution on that one.

--- a/mm/memremap.c~mm-memremap_pages-replace-zone_device_page_init-with-pgmap_request_folios-fix
+++ a/mm/memremap.c
@@ -518,18 +518,6 @@ void free_zone_device_page(struct page *
 		put_dev_pagemap(page->pgmap);
 }
 
-void zone_device_page_init(struct page *page)
-{
-	/*
-	 * Drivers shouldn't be allocating pages after calling
-	 * memunmap_pages().
-	 */
-	WARN_ON_ONCE(!percpu_ref_tryget_live(&page->pgmap->ref));
-	set_page_count(page, 1);
-	lock_page(page);
-}
-EXPORT_SYMBOL_GPL(zone_device_page_init);
-
 static __maybe_unused bool folio_span_valid(struct dev_pagemap *pgmap,
 					    struct folio *folio,
 					    int nr_folios)
_