Re: [PATCH v3 2/2] dt-bindings: add bindings for QCOM flash LED

[Fenglin Wu]

On 2022/10/19 21:36, Krzysztof Kozlowski wrote:
> On 17/10/2022 21:40, Fenglin Wu wrote:
> > Add binding document for flash LED module inside Qualcomm Technologies,
> > Inc. PMICs.
>
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>
> This means:
> 1. you miss subsystem prefix
> 2. drop redundant second "bindings"
>
> > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > ---
> >   .../bindings/leds/qcom,spmi-flash-led.yaml    | 116 ++++++++++++++++++
> >   1 file changed, 116 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> > new file mode 100644
> > index 000000000000..d8efde02db72
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> > @@ -0,0 +1,116 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/qcom,spmi-flash-led.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Flash LED device inside Qualcomm Technologies, Inc. PMICs
> > +
> > +maintainers:
> > +  - Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > +
> > +description: |
> > +  Flash LED controller is present inside some Qualcomm Technologies, Inc. PMICs.
> > +  The flash LED module can have different number of LED channels supported
> > +  e.g. 3 or 4. There are some different registers between them but they can
> > +  both support maximum current up to 1.5 A per channel and they can also support
> > +  ganging 2 channels together to supply maximum current up to 2 A. The current
> > +  will be split symmetrically on each channel and they will be enabled and
> > +  disabled at the same time.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - qcom,pm8150c-flash-led
> > +          - qcom,pm8150l-flash-led
> > +          - qcom,pm8350c-flash-led
> > +      - const: qcom,spmi-flash-led
>
> Blank line
>
> > +  reg:
> > +    description: address offset of the flash LED controller
>
> Drop description, it's obvious.
>
> > +    maxItems: 1
> > +
> > +patternProperties:
> > +  "^led-[0-3]$":
> > +    type: object
> > +    $ref: common.yaml#
> > +    unevaluatedProperties: false
> > +    description: |
>
> No need for |
>
> > +      Represents the physical LED components which are connected to the
> > +      flash LED channels' output.
> > +
> > +    properties:
> > +      led-sources:
> > +        description: |
>
> No need for |
>
> Rest looks good:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
Thanks you Krzysztof! I will address them when pushing next patch.