Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt

[Cixi Geng]

Vinod Koul <vkoul@xxxxxxxxxx> 于2022年10月19日周三 22:07写道：
>
> On 04-10-22, 07:49, Cixi Geng wrote:
> > From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
> >
> > Audio need to request Audio CP global dma interrupt, so Audio CP
> > DMA should support two-stage interrupt to adapte it.
> > It will occur interrupt when two-stage dma channel transfer done.
>
> The patch looks fine to me but...
>
> > diff --git a/include/linux/dma/sprd-dma.h b/include/linux/dma/sprd-dma.h
> > index d09c6f6f6da5..26de41d6d915 100644
> > --- a/include/linux/dma/sprd-dma.h
> > +++ b/include/linux/dma/sprd-dma.h
>
> >  enum sprd_dma_int_type {
> >       SPRD_DMA_NO_INT,
> > @@ -112,6 +120,10 @@ enum sprd_dma_int_type {
> >       SPRD_DMA_TRANS_BLK_INT,
> >       SPRD_DMA_LIST_INT,
> >       SPRD_DMA_CFGERR_INT,
> > +     SPRD_DMA_SRC_CHN0_INT,
> > +     SPRD_DMA_SRC_CHN1_INT,
> > +     SPRD_DMA_DST_CHN0_INT,
> > +     SPRD_DMA_DST_CHN1_INT,
>
> why is sprd_dma_int_type part of driver interface. sprd_dma_int_type is
> used only by this driver and should be moved into the driver..
>
> Can you change that as well please
the two-stage interrupts added need more discuss and test,
anyway, I can create a new patch for the change to move init_type into driver,
>
> --
> ~Vinod