Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls

From: Jonathan Cameron
Date: Thu Oct 20 2022 - 06:36:00 EST


On Wed, 19 Oct 2022 23:37:51 +0200
Wolfram Sang <wsa-dev@xxxxxxxxxxxxxxxxxxxx> wrote:

> > I spent a little time trying to put together a Coccinelle script to
> > take care of everything but I eventually realized the size of the task
> > was larger than I was comfortable with. In particular, even though I
> > might be able to put together a script, I worry I don't have a good
> > way to test the resulting treewide changes to avoid regression.
>
> The coccinelle scripts are one thing. I am quite familiar with it, so I
> regard this as "work but doable". My main headache is that I am not sure
> about the best way to upstream the result. I'd like to avoid a flag-day
> where all drivers across all subsystems need to be converted, but I
> don't really see a way around it. Preparing such a branch and make sure
> it does not regress is quite some work on a moving target.

Horrendous though it is, you 'could' take it via a void * intermediate
step. That way all the warnings will disappear (I think).
You then move all the callers to providing u8 * then switch the function
to that. Could happen over several cycles with coccicheck moaning about
any new entries in the meantime.

Jonathan


>
>