Re: [PATCH] tracing/hist: add in missing * in comment blocks

[Google]

Hi,

On Thu, 20 Oct 2022 14:30:19 +0100
Colin Ian King <colin.i.king@xxxxxxxxx> wrote:

> There are a couple of missing * in comment blocks. Fix these.
> Cleans up two clang warnings:
> 
> kernel/trace/trace_events_hist.c:986: warning: bad line:
> kernel/trace/trace_events_hist.c:3229: warning: bad line:
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Thanks for the patch. 

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

BTW, what version of clang are you using?
I couldn't see this warning with clang 15.0.0. Maybe I need a kconfig option?

Thank you,

> ---
>  kernel/trace/trace_events_hist.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 48465f7e97b4..087c19548049 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data,
>   * A trigger can define one or more variables.  If any one of them is
>   * currently referenced by any other trigger, this function will
>   * determine that.
> -
> + *
>   * Typically used to determine whether or not a trigger can be removed
>   * - if there are any references to a trigger's variables, it cannot.
>   *
> @@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data,
>   * events.  However, for convenience, users are allowed to directly
>   * specify an event field in an action, which will be automatically
>   * converted into a variable on their behalf.
> -
> + *
>   * This function creates a field variable with the name var_name on
>   * the hist trigger currently being defined on the target event.  If
>   * subsys_name and event_name are specified, this function simply
> -- 
> 2.37.3
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>