Re: [PATCH v5 06/10] pwm: dwc: split pci out of core driver

[Ben Dooks]

On 10/10/2022 11:39, Jarkko Nikula wrote:
> Hi
>
> On 10/6/22 01:12, Ben Dooks wrote:
> > Moving towards adding non-pci support for the driver, move the pci
> > parts out of the core into their own module. This is partly due to
> > the module_driver() code only being allowed once in a module and also
> > to avoid a number of #ifdef if we build a single file in a system
> > without pci support.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxx>
> > ---
> > v4:
> >   - removed DWC_PERIOD_NS as not needed
>
> ...
>
> > --- a/drivers/pwm/pwm-dwc.c
> > +++ b/drivers/pwm/pwm-dwc.c
> > -
> > -#define DWC_TIMERS_TOTAL    8
> > -#define DWC_CLK_PERIOD_NS    10
> > -
>
> Actually DWC_CLK_PERIOD_NS is still used here. Only the next patch 07/10 
> is removing usage of it so this patch is not bisect safe.

Ok, will fix for v6.