RE: [PATCH v2 03/12] cxl: Unify debug messages when calling devm_cxl_add_port()
From: Dan Williams
Date: Thu Oct 20 2022 - 20:20:34 EST
Robert Richter wrote:
> CXL ports are added in a couple of code paths using devm_cxl_add_
> port(). Debug messages are individually generated, but are incomplete
Hmm, devm_cxl_add_port() got wrapped in a few places here. I fixed it up
locally, but maybe take a look at your word wrap to keep function
symbols unbroken in future changelogs.
> and inconsistent. Change this by moving its generation to devm_cxl_
> add_port(). This unifies the messages and reduces code duplication.
> Also, generate messages on failure. Use a __devm_cxl_add_port()
> wrapper to keep the readability of the error exits.
Otherwise looks good, applied for v6.2.