Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names

[AngeloGioacchino Del Regno]

Il 21/10/22 08:25, Chunfeng Yun ha scritto:
> On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote:
> > Il 14/10/22 04:43, Chunfeng Yun ha scritto:
> > > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno
> > > wrote:
> > > > Update the names to regulator-usb-p{0-3}-vbus to fix
> > > > unit_address_vs_reg
> > > > warnings for those.
> > > >
> > > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for
> > > > MT2712")
> > > > Signed-off-by: AngeloGioacchino Del Regno <
> > > > angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
> > > >    1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > > index 638908773706..d31a194124c9 100644
> > > > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> > > > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
> > > >    		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
> > > >    	};
> > > >    
> > > > -	usb_p0_vbus: regulator@2 {
> > > > +	usb_p0_vbus: regulator-usb-p0-vbus {
> > >
> > > Can we modify dt-binding of fixed regulator instead of changing the
> > > node name,
> > > since all nodes using fixed regulator may need be changed.
> >
> > These regulators have no MMIO, nor need any index, so it would be
> > simply
> > wrong to change the binding and leave them as they are here in the
> > devicetree.
> You are right, then many files need be modified?

Yes Chunfeng, many files need to be modified due to mistakes made in the past.

No big deal though: as long as we're all aware of what needs to happen, it's fine!

Cheers,
Angelo