Re: BISECT result: 6.0.0-RC kernels trigger Firefox snap bug with 6.0.0-rc3 through 6.0.0-rc7

[Mirsad Goran Todorovac]

On 21.10.2022. 3:48, Phillip Lougher wrote:

> On 21/10/2022 00:44, Slade Watkins wrote:
> > [Resend due to formatting issue, thanks gmail.]
> >
> > On Thu, Oct 20, 2022 at 7:23 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> 
> > wrote:
> > > Ah! I was about to test his third fixup patch. I prefer to go
> > > with your fix instead (as the formal patch).
> >
> > +1, agreed.
> >
> > -srw
>
> His patch is wrong, plus he's broken a number of rules of conduct, two 
> serious.  But, I will not reprimand him as kernel maintainer for what is
> probably extreme naivety, unless I have to.
>
> The link to the full set of patches is here
>
> https://lore.kernel.org/lkml/20221020223616.7571-1-phillip@xxxxxxxxxxxxxxx/ 
>
>
> The first patch fixes the regression reported here in the correct way.
>
> The second patch fixes another regression (which is separate to the
> regression causing the issue here).  This is where the code incorrectly
> extends readahead beyond the end of the file.  This is the reason for
> the unused trailing pages that Jintao Yin noticed.  But, this patch
> fixes the cause, rather than fixing the symptom.
>
> The third patch fixes the buffer release race condition that I
> posted a fix for earlier.
>
> Spitting this into three patches is one of the rules.  Each patch should
> do one thing, and one thing only.  Three separate regressions means
> three separate patches.  This is a requirement for "git bisect" to work
> effectively.

Confirming successful build mainline vanilla 6.0.2 with patches [012/3].

And the combination of Firefox snap windows and tabs that reproduced the 
regression
appears to work.

Best regards,
Mirsad

--
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union
--
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu