Re: [PATCH 6.0 681/862] wifi: rtw88: phy: fix warning of possible buffer overflow

[Greg Kroah-Hartman]

On Fri, Oct 21, 2022 at 12:12:29AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Wednesday, October 19, 2022 4:33 PM
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx; Kevin Yang
> > <kevin_yang@xxxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Sasha Levin
> > <sashal@xxxxxxxxxx>
> > Subject: [PATCH 6.0 681/862] wifi: rtw88: phy: fix warning of possible buffer overflow
> > 
> > From: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx>
> > 
> > [ Upstream commit 86331c7e0cd819bf0c1d0dcf895e0c90b0aa9a6f ]
> > 
> > reported by smatch
> > 
> > phy.c:854 rtw_phy_linear_2_db() error: buffer overflow 'db_invert_table[i]'
> > 8 <= 8 (assuming for loop doesn't break)
> > 
> > However, it seems to be a false alarm because we prevent it originally via
> >        if (linear >= db_invert_table[11][7])
> >                return 96; /* maximum 96 dB */
> > 
> > Still, we adjust the code to be more readable and avoid smatch warning.
> 
> Like Pavel mentioned [1], this patch is to avoid smatch warning, not a really
> bug. So, shouldn't take this patch. 
> 
> [1] https://lore.kernel.org/linux-wireless/20221018093921.GD1264@xxxxxxxxxx/

Ok, will go drop now, thanks.

greg k-h