Re: [PATCH v4 09/11] rtc: pm8xxx: drop unused pm8018 compatible

From: Konrad Dybcio
Date: Fri Oct 21 2022 - 05:17:30 EST




On 21.10.2022 11:06, Neil Armstrong wrote:
> The PM8018 compatible is always used with PM8921 fallback, so PM8018
> compatible can be safely removed from device ID table
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>

Konrad
> drivers/rtc/rtc-pm8xxx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index dc6d1476baa5..716e5d9ad74d 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -461,7 +461,6 @@ static const struct pm8xxx_rtc_regs pmk8350_regs = {
> */
> static const struct of_device_id pm8xxx_id_table[] = {
> { .compatible = "qcom,pm8921-rtc", .data = &pm8921_regs },
> - { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
> { .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
> { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
> { .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
>