Re: [PATCH v2 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver

From: Herbert Xu
Date: Fri Oct 21 2022 - 07:15:52 EST


On Wed, Sep 28, 2022 at 03:37:59PM +0800, 'Guanjun' wrote:
>
> diff --git a/drivers/crypto/ycc/Makefile b/drivers/crypto/ycc/Makefile
> new file mode 100644
> index 00000000..7065273
> --- /dev/null
> +++ b/drivers/crypto/ycc/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-(CONFIG_CRYPTO_DEV_YCC) += ycc.o
> +ycc-objs := ycc_drv.o ycc_isr.o

This doesn't even compile. When I fixed that it generates loads
of warnings with sparse turned on. Please fix them all before you
resubmit.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt