Re: [PATCH v4 2/4] dt-bindings: arm: mediatek: Add new bindings of MediaTek frequency hopping

[Johnson Wang (王聖鑫)]

On Mon, 2022-10-17 at 12:04 -0700, Stephen Boyd wrote:
> Quoting Johnson Wang (王聖鑫) (2022-10-17 05:55:09)
> > On Fri, 2022-10-14 at 13:42 -0700, Stephen Boyd wrote:
> > > Quoting Johnson Wang (2022-10-13 04:23:34)
> > > > +  - |
> > > > +    #include <dt-bindings/clock/mt8186-clk.h>
> > > > +    fhctl: fhctl@1000ce00 {
> > > 
> > > Is it a clock-controller? 'fhctl' isn't a generic node name.
> > > 
> > 
> > This node is used for determining if PLLs adopt "hopping" method to
> > adjust their frequency.
> > It doesn't provide any clock but actually change the behavior of
> > some
> > PLLs with new .set_rate callback.
> > Do you think this node acts like one kind of clock-controller?
> 
> Why can't we add the reg and properties to the node that implements
> the
> PLL?

Hi Stephen,

Now we use standard clocks property to get clock indices from
apmixedsys node.

If we integrate the reg and properties into apmixedsys node, we have to
figure out another way to get indices... (I think one node shouldn't
take itself as input?)

There is an idea in my mind. Add these prperties into apmixedsys node.

	mediatek,hopping-clocks = <CLK_APMIXED_MAINPLL>,
			          <CLK_APMIXED_MSDCPLL>;
	mediatek,ssc-percent = <2 3>;


But I don't really know if this violates some rules.
Could you please give us some suggestion?
Thanks!

BRs,
Johnson Wang