Re: [PATCH] crypto: tcrypt - fix return value for multiple subtests

From: Herbert Xu
Date: Fri Oct 21 2022 - 07:36:29 EST


On Fri, Sep 30, 2022 at 04:40:14PM -0500, Robert Elliott wrote:
> When a test mode invokes multiple tests (e.g., mode 0 invokes modes
> 1 through 199, and mode 3 tests three block cipher modes with des),
> don't keep accumulating the return values with ret += tcrypt_test(),
> which results in a bogus value if more than one report a nonzero
> value (e.g., two reporting -2 (-ENOENT) end up reporting -4 (-EINTR)).
> Instead, keep track of the minimum return value reported by any
> subtest.
>
> Fixes: 4e033a6bc70f ("crypto: tcrypt - Do not exit on success in fips mode")
> Signed-off-by: Robert Elliott <elliott@xxxxxxx>
> ---
> crypto/tcrypt.c | 256 ++++++++++++++++++++++++------------------------
> 1 file changed, 128 insertions(+), 128 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt