Re: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD

[Krzysztof Kozlowski]

On 21/10/2022 04:12, Padmanabhan Rajanbabu wrote:
> 
> 
>> -----Original Message-----
>> From: Alim Akhtar [mailto:alim.akhtar@xxxxxxxxxxx]
>> Sent: 14 October 2022 06:59 PM
>> To: 'Padmanabhan Rajanbabu' <p.rajanbabu@xxxxxxxxxxx>;
>> lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
>> krzysztof.kozlowski+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx;
>> perex@xxxxxxxx; tiwai@xxxxxxxx; pankaj.dubey@xxxxxxxxxxx;
>> rcsekar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx
>> Cc: alsa-devel@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx
>> Subject: RE: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
>>
>>
>>
>>> -----Original Message-----
>>> From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@xxxxxxxxxxx]
>>> Sent: Friday, October 14, 2022 3:52 PM
>>> To: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
>>> krzysztof.kozlowski+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx;
>>> perex@xxxxxxxx; tiwai@xxxxxxxx; pankaj.dubey@xxxxxxxxxxx;
>>> alim.akhtar@xxxxxxxxxxx; rcsekar@xxxxxxxxxxx;
>> aswani.reddy@xxxxxxxxxxx
>>> Cc: alsa-devel@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
>>> kernel@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
>> Padmanabhan
>>> Rajanbabu <p.rajanbabu@xxxxxxxxxxx>
>>> Subject: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
>>>
>>> Add device tree node support for sound card on Tesla FSD board
>>>
>>> Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx>
>>> ---
>>> arch/arm64/boot/dts/tesla/fsd-evb.dts | 49
>>> +++++++++++++++++++++++++++
>>> arch/arm64/boot/dts/tesla/fsd.dtsi    |  3 ++
>>> 2 files changed, 52 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
>>> b/arch/arm64/boot/dts/tesla/fsd-evb.dts
>>> index c0a4509499ab..ecaa3c2e3045 100644
>>> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
>>> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
>>> @@ -49,3 +49,52 @@
>>> &tdm_1 {
>>> 	status = "okay";
>>> };
>>> +
>>> +&sound {
>>> +	compatible = "tesla,fsd-sndcard";
>>> +	status = "okay";
>>> +	model = "fsd-i2s";
>>> +	widgets =
>>> +		"Speaker", "MAIN SPK",
>>> +		"Microphone", "MAIN MIC";
>>> +
>>> +	primary-dai-link-0 {
>>> +		link-name = "fsd-primary-0";
>>> +		dai-format = "i2s";
>>> +		tesla,bitclock-master = <&tdm_0>;
>>> +		tesla,frame-master = <&tdm_0>;
>>> +		cpu {
>>> +			sound-dai = <&tdm_0 0>;
>>> +		};
>>> +	};
>>> +
>>> +	secondary-dai-link-0 {
>>> +		link-name = "fsd-secondary-0";
>>> +		dai-format = "i2s";
>>> +		tesla,bitclock-master = <&tdm_0>;
>>> +		tesla,frame-master = <&tdm_0>;
>>> +		cpu {
>>> +			sound-dai = <&tdm_0 1>;
>>> +		};
>>> +	};
>>> +
>>> +	primary-dai-link-1 {
>>> +		link-name = "fsd-primary-1";
>>> +		dai-format = "i2s";
>>> +		tesla,bitclock-master = <&tdm_1>;
>>> +		tesla,frame-master = <&tdm_1>;
>>> +		cpu {
>>> +			sound-dai = <&tdm_1 0>;
>>> +		};
>>> +	};
>>> +
>>> +	secondary-dai-link-1 {
>>> +		link-name = "fsd-secondary-1";
>>> +		dai-format = "i2s";
>>> +		tesla,bitclock-master = <&tdm_1>;
>>> +		tesla,frame-master = <&tdm_1>;
>>> +		cpu {
>>> +			sound-dai = <&tdm_1 1>;
>>> +		};
>>> +	};
>>> +};
>>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> index 5decad45a1b6..fc8931f830a7 100644
>>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> @@ -847,6 +847,9 @@
>>> 			status = "disabled";
>>> 		};
>>>
>>> +		sound: sound {
>>> +		};
>>> +
>> Why to have an empty node in dtsi?
> This is required as every node we use in dts should have the same declared in

I see no reason why this is required.

> dtsi. Sound nodes in most of the platform is only declared (dummy node) in
> dtsi and defining only in dts. Thus we are following the same.

Can you point me to Samsung platform doing this?

Keep the code consistent with Exynos style.

Best regards,
Krzysztof