Re: [PATCH 2/5] x86/microcode: Simplify init path even more

From: Borislav Petkov
Date: Fri Oct 21 2022 - 09:31:12 EST


On Fri, Oct 21, 2022 at 04:39:55AM -0700, Ashok Raj wrote:
> I tested just with only your patches

Yeah, it can't work:

[ 1.365806] microcode: microcode_init: will request
[ 1.365812] microcode: request_microcode_fw: name: intel-ucode/06-3a-09
[ 1.365999] platform microcode: loading /lib/firmware/updates/6.1.0-rc1+/intel-ucode/06-3a-09 failed for no such file or directory.
[ 1.366032] platform microcode: loading /lib/firmware/updates/intel-ucode/06-3a-09 failed for no such file or directory.
[ 1.366061] platform microcode: loading /lib/firmware/6.1.0-rc1+/intel-ucode/06-3a-09 failed for no such file or directory.
[ 1.366088] platform microcode: loading /lib/firmware/intel-ucode/06-3a-09 failed for no such file or directory.
[ 1.366092] firmware_class: _request_firmware: fw_get_filesystem_firmware: retval: -2
[ 1.366096] platform microcode: Direct firmware load for intel-ucode/06-3a-09 failed with error -2
[ 1.366174] firmware_class: request_firmware_direct: ret: -2
[ 1.366178] microcode: data file intel-ucode/06-3a-09 load failed
[ 1.366248] microcode: sig=0x306a9, pf=0x10, revision=0x21
[ 1.366380] microcode: Microcode Update Driver: v2.2.

because that happens before the hdd driver has even been loaded yet.

My assumption that late_initcall() is late enough was wrong.

But that's ok - it was a weird use case anyway. One is supposed to use
early loading anyway.

Ok, lemme remove that loading attempt and test them more.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette