Re: [PATCH 0/5] padata: fix liftime issues after ->serial() has completed

From: Daniel Jordan
Date: Fri Oct 21 2022 - 17:36:15 EST


Hi Nicolai,

On Wed, Oct 19, 2022 at 10:37:03AM +0200, Nicolai Stange wrote:
> Hi all,
>
> this series is supposed to fix some lifetime issues all related to the fact that
> once the last ->serial() has been invoked, the padata user (i.e. pcrypt) is well
> with its right to tear down the associated padata_shell or parallel_data
> instance respectively.
>
> Only the first one, addressed by patch [2/5], has actually been observed, namely
> on a (downstream) RT kernel under a very specific workload involving LTP's
> pcrypt_aead01. On non-RT, I've been unable to reproduce.

I haven't been able to hit the issue in 2/5 on RT on a v6.0 kernel in an
x86 vm. Were there any other things running on the system besides
pcrypt_aead01? More details about your environment and your kernel
config would be helpful.

The first two patches seem ok but I want to think about the second more
next week. I'll look over the rest of the series then too.