Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate_disk is called

[yangxingui]

On 2022/10/20 8:18, Martin K. Petersen wrote:
> Xingui,
>
> > When the host protection capabilities are 0x77 and a DIF disk is
> > connected, the DIX and DIF of the disk are default enabled. Then if
> > that DIF disk is reformatted as a non-DIF format, per the currently
> > flow, the DIX is kept enabled which is not correct
> DIX is orthogonal to DIF and a host property. DIX should not be disabled
> just because the disk is no longer formatted with protection
> information.

As the host protection capabilities are 0x77 and not support DIX between 
OS and HBA only.

If write command is delivered to a non-DIF disk with DIX format this 
time, I/Os will be failed.

DIX status should  be updated when the disk DIF type changes.

> That said, your patch is probably fine. I'll take a closer look
> tomorrow.

ok, thanks.

Xingui

>