Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('

From: Joe Perches
Date: Sat Oct 22 2022 - 03:19:08 EST


On Sat, 2022-10-22 at 07:06 +0000, Tanjuate Brunostar wrote:
> fix serveral checkpatch errors related to lines ending with a '(' by
> refactoring the code lines
[]
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
[]
> @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> */
> static
> unsigned int
> -s_uGetTxRsvTime(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - unsigned int cbFrameLength,
> - unsigned short wRate,
> - bool bNeedAck
> -)
> +s_uGetTxRsvTime(struct vnt_private *pDevice,

If you end up doing more work here, ou might consider removing the
Hungarian style notations

Maybe something like:

s_uGetTxRsvTime -> get_tx_rsv_time

> + unsigned char byPktType,

byPktType -> pkt_type

etc...

Perhaps patches by unique rename.