Re: [PATCH v4 2/6] usb: dwc3: gadget: cancel requests instead of release after missed isoc
From: Greg Kroah-Hartman
Date: Sat Oct 22 2022 - 07:40:14 EST
On Tue, Oct 18, 2022 at 04:50:38PM -0500, Dan Vacura wrote:
> From: Jeff Vanhoof <qjv001@xxxxxxxxxxxx>
>
> arm-smmu related crashes seen after a Missed ISOC interrupt when
> no_interrupt=1 is used. This can happen if the hardware is still using
> the data associated with a TRB after the usb_request's ->complete call
> has been made. Instead of immediately releasing a request when a Missed
> ISOC interrupt has occurred, this change will add logic to cancel the
> request instead where it will eventually be released when the
> END_TRANSFER command has completed. This logic is similar to some of the
> cleanup done in dwc3_gadget_ep_dequeue.
>
> Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Jeff Vanhoof <qjv001@xxxxxxxxxxxx>
> Co-developed-by: Dan Vacura <w36195@xxxxxxxxxxxx>
> Signed-off-by: Dan Vacura <w36195@xxxxxxxxxxxx>
> ---
> V1 -> V3:
> - no change, new patch in series
> V3 -> V4:
> - no change
I need an ack from the dwc3 maintainer before I can take this one.
thanks,
greg k-h