Re: [PATCH v2] counter: microchip-tcb-capture: Handle Signal1 read and Synapse

[William Breathitt Gray]

On Tue, Oct 18, 2022 at 08:10:14AM -0400, William Breathitt Gray wrote:
> The signal_read(), action_read(), and action_write() callbacks have been
> assuming Signal0 is requested without checking. This results in requests
> for Signal1 returning data for Signal0. This patch fixes these
> oversights by properly checking for the Signal's id in the respective
> callbacks and handling accordingly based on the particular Signal
> requested. The trig_inverted member of the mchp_tc_data is removed as
> superfluous.
> 
> Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
> Signed-off-by: William Breathitt Gray <william.gray@xxxxxxxxxx>
> ---
> Changes in v2:
>  - Simplified action_read() changes to just handle qdec_mode and
>    non-TIOA Signals before continuing with existing code

Queued for counter-fixes.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature