RE: [PATCH 1/1] linux/container_of.h: Warn about loss of constness
From: David Laight
Date: Mon Oct 24 2022 - 04:59:42 EST
From: Greg Kroah-Hartman
> Sent: 24 October 2022 09:44
...
> > + * WARNING: as container_of() casts the given struct to another, also the
>
> No need for "also" here (sorry for the grammar nit.)
>
> > + * possible const qualifier of @ptr is lost unless it is also specified in
> > + * @type. This is not a problem if the containing object is not const. Use with
> > + * care.
>
> I do not think these last two sentences you added here are needed
> either.
It is all TL;DR :-)
Even just:
NOTE: any const qualifier of @ptr is lost.
Is probably more than enough.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)