Re: [PATCH] arm64: dts: qcom: sc8280xp: add TCSR node

From: Johan Hovold
Date: Mon Oct 24 2022 - 11:07:54 EST


On Mon, Oct 24, 2022 at 09:34:22AM -0400, Krzysztof Kozlowski wrote:
> On 24/10/2022 08:58, Johan Hovold wrote:
> > Add the TCSR node which is needed for PCIe configuration.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++
>
> Please send the patches together with the binding. There is no need to
> have this split and it causes additional effort during review - lookup
> of the binding.

I was under the impression that the dts changes should be submitted
separately from the binding as they go through different trees. (And
last time I posted them together the subsystem maintainer ended up
taking also the dts changes by mistake).

The binding has been picked up by Lee now so I posted the dts change.
Could have added a lore link though.

> Also additional effort during binding review - lack of usage of bindings.
>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Johan