Re: [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE()

From: Andy Shevchenko
Date: Mon Oct 24 2022 - 13:34:48 EST


On Mon, Oct 24, 2022 at 06:44:50PM +0300, Alexey Dobriyan wrote:
> > include/linux/array_size.h | 13 +++++++++++++
>
> All of this is pessimisation unless you're removing
>
> +#include <linux/array_size.h>
>
> from kernel.h which you aren't doing.
>
> container_of.h is just as silly.
>
> kernel.h might need _some_ cleanup (like panic and tainted stuff) which
> is rarely used but ARRAY_SIZE()?

Are you suggesting to slow down compilation with inclusion of tons of unneeded
stuff in the zillions of drivers?

Or you are talking that we need to abandon most of the headers and combine
everything into kernel.h? I think this is what is silly.


--
With Best Regards,
Andy Shevchenko