Re: [PATCH] net/mptcp: fix repeated words in comments

From: Mat Martineau
Date: Mon Oct 24 2022 - 19:47:59 EST


On Sun, 23 Oct 2022, Bagas Sanjaya wrote:

On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
Delete the redundant word 'the'.

Signed-off-by: wangjianli <wangjianli@xxxxxxxxxx>
---
net/mptcp/token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index f52ee7b26aed..b817c2564300 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
* This function returns the first mptcp connection structure found inside the
* token container starting from the specified position, or NULL.
*
- * On successful iteration, the iterator is move to the next position and the
+ * On successful iteration, the iterator is move to the next position and
* the acquires a reference to the returned socket.
*/
struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,

NAK!

Instead, slightly reword the comment above as "On successful iteration,
the iterator moves to the next position and acquires a reference to the
returned socket.".


Agree on this rewording.

This particular duplicated word came up before, and I thought it would be best if the author sent a v2 - but they never did. I will fix this in the MPTCP tree next week if there's no suitable v2 by then.

--
Mat Martineau
Intel