Re: [PATCH v3 1/2] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme

From: Vadym Kochan
Date: Mon Oct 24 2022 - 21:14:39 EST


Hi Krzysztof,

On Mon, 24 Oct 2022 17:31:48 -0400, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 24/10/2022 17:01, Vadym Kochan wrote:
> > Switch the DT binding to a YAML schema to enable the DT validation.
> >
> > Dropped deprecated compatibles and properties described in txt file.
> >
> > Signed-off-by: Vadym Kochan <vadym.kochan@xxxxxxxxxxx>
> > ---
> >
> > v3:
> > 1) Remove txt version from the MAINTAINERS list
> >
> > 2) Use enum for some of compatible strings
> >
> > 3) Drop:
> > #address-cells
> > #size-cells:
> >
> > as they are inherited from the nand-controller.yaml
> >
> > 4) Add restriction to use 2 clocks for A8K SoC
> >
> > 5) Dropped description for clock-names and extend it with
> > minItems: 1
> >
> > 6) Drop description for "dmas"
> >
> > 7) Use "unevalautedProperties: false"
>
> Hmm... In one place it makes sense. In "nand@" not really.
>
> >
> > 8) Drop quites from yaml refs.
> >
> > 9) Use 4-space indentation for the example section
> >
> > v2:
> > 1) Fixed warning by yamllint with incorrect indentation for compatible list
> >
> > .../bindings/mtd/marvell,nand-controller.yaml | 189 ++++++++++++++++++
> > .../devicetree/bindings/mtd/marvell-nand.txt | 126 ------------
> > MAINTAINERS | 1 -
> > 3 files changed, 189 insertions(+), 127 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> > delete mode 100644 Documentation/devicetree/bindings/mtd/marvell-nand.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> > new file mode 100644
> > index 000000000000..cb20f14d4aea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> > @@ -0,0 +1,189 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell NAND Flash Controller (NFC)
> > +
> > +maintainers:
> > + - Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > +
> > +

[...]

> > + nand-ecc-step-size:
> > + description: |
> > + Marvell's NAND flash controller does use fixed strength
> > + (1-bit for Hamming, 16-bit for BCH), so the actual step size
> > + will shrink or grow in order to fit the required strength.
> > + Step sizes are not completely random for all and follow certain
> > + patterns described in AN-379, "Marvell SoC NFC ECC".
> > +
> > + label:
> > + $ref: /schemas/types.yaml#/definitions/string
> > +
> > + partitions:
> > + type: object
> > + $ref: /schemas/mtd/partitions/partition.yaml
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>

I see that I have to drop "label" and "partitions" properties.

> > +
> > + marvell,nand-keep-config:
> > + description: |
> > + Orders the driver not to take the timings from the core and
> > + leaving them completely untouched. Bootloader timings will then
> > + be used.
> > + $ref: /schemas/types.yaml#/definitions/flag
> > +
> > + marvell,nand-enable-arbiter:
> > + description: |
> > + To enable the arbiter, all boards blindly used it,
> > + this bit was set by the bootloader for many boards and even if
> > + it is marked reserved in several datasheets, it might be needed to set
> > + it (otherwise it is harmless) so whether or not this property is set,
> > + the bit is selected by the driver.
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + deprecated: true
> > +
> > + unevaluatedProperties: false
>
> This looks wrong. I do not see referencing schema here and I did not ask
> to change it.

Yes, I will drop it.

>
> > +
> > + required:
> > + - reg
> > + - nand-rb
> > +
> > +unevaluatedProperties: false
>
> This one is ok.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > +
> > +allOf:
> > + - $ref: nand-controller.yaml#
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: marvell,pxa3xx-nand-controller
> > + then:
> > + required:
> > + - dmas
> > + - dma-names
> > + else:
> > + properties:
> > + dmas: false
> > + dma-names: false
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: marvell,armada-8k-nand-controller
> > + then:
> > + required:
> > + - marvell,system-controller
> > + properties:
> > + clocks:
> > + minItems: 2
>
> Also for clock-names "minItems: 2"
>
> > + else:
> > + properties:
> > + marvell,system-controller: false
>
> clocks:
> maxItems: 1
>

OK, so it goes under the "else".

> and the same for clock-names... unless these variants also have two clocks?
>
>
> Best regards,
> Krzysztof
>

Thank you,
Vadym