Re: [PATCH] f2fs: make gc_idle sysfs node readable

[Chao Yu]

On 2022/10/21 16:26, Yangtao Li wrote:
> Changed a way of showing values of them to use strings.

This change breaks forward compatibility of gc_idle interface.

Thanks,

> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
>   fs/f2fs/sysfs.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index b4476adea776..555849d4c744 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -332,6 +332,10 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a,
>   		return sysfs_emit(buf, "%u\n", sbi->compr_new_inode);
>   #endif
>   
> +	if (!strcmp(a->attr.name, "gc_idle"))
> +		return sysfs_emit(buf, "%s\n",
> +				gc_mode_names[sbi->gc_mode]);
> +
>   	if (!strcmp(a->attr.name, "gc_urgent"))
>   		return sysfs_emit(buf, "%s\n",
>   				gc_mode_names[sbi->gc_mode]);