Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe

[Dongliang Mu]

> On Oct 24, 2022, at 20:00, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
>> The commit 1149108e2fbf ("can: mscan: improve clock API use
>> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
> 
> Strange indentation. Why the '")' part can't be on the previous line?

:/ it is automatically done by vim in `git commit -a -s -e`. I can adjust this part in v2 patch.

> 
>> put_clock in the error handling code.
>> 
>> Fix this bug by adding put_clock in the error handling code.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
>