Re: [PATCH 1/1] ARM: dts: aspeed: bletchley: add aliases for mdio0 and mdio3

[Joel Stanley]

On Tue, 25 Oct 2022 at 02:43, Potin Lai <potin.lai.pt@xxxxxxxxx> wrote:
>
> Add aliases for mdio0 and mdio3 so that we can use name to lookup the
> address of Aspeed SOC.
>
> For example:
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio0
> /ahb/mdio@1e650000
> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio3
> /ahb/mdio@1e650018
>
> Signed-off-by: Potin Lai <potin.lai.pt@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index c02c15f15465..2825d5f3f78b 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -15,6 +15,8 @@ / {
>
>         aliases {
>                 serial4 = &uart5;
> +               mdio0 = &mdio0;
> +               mdio3 = &mdio3;

Should this go into the dtsi instead?

>         };
>
>         chosen {
> --
> 2.31.1
>