RE: [PATCH net-next 2/2] net: stmmac: remove duplicate dma queue channel macros

From: Chang, Junxiao
Date: Tue Oct 25 2022 - 03:36:48 EST


Hi Wee Khee,

Good suggestion! 😊

I will make related update.

Regards,
Junxiao

-----Original Message-----
From: Wong Vee Khee <veekhee@xxxxxxxxx>
Sent: Tuesday, October 25, 2022 3:11 PM
To: Chang, Junxiao <junxiao.chang@xxxxxxxxx>
Cc: Joao.Pinto@xxxxxxxxxxxx; alexandre.torgue@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; joabreu@xxxxxxxxxxxx; kuba@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; mcoquelin.stm32@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; pabeni@xxxxxxxxxx; peppe.cavallaro@xxxxxx
Subject: Re: [PATCH net-next 2/2] net: stmmac: remove duplicate dma queue channel macros

Why not combine with the other ‘if (queue < 4).. else’ in this function all together?

Regards,
Vee Khee