Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the APCB

From: David Hildenbrand
Date: Tue Oct 25 2022 - 05:31:17 EST


On 25.10.22 11:13, Pierre Morel wrote:
The APCB is part of the CRYCB.
The calculation of the APCB origin can be done by adding
the APCB offset to the CRYCB origin.

Current code makes confusing transformations, converting
the CRYCB origin to a pointer to calculate the APCB origin.



While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to "apcb_gpa".

These are not pointers but guest physical addresses.

--
Thanks,

David / dhildenb