Re: [PATCH] firmware/psci: demote suspend-mode warning to debug level

[Dmitry Baryshkov]

On 24/10/2022 17:34, Johan Hovold wrote:
> On some Qualcomm platform, like SC8280XP, the attempt to set PC mode
> during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb
> ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this
> is now logged at warning level:
>
> 	psci: failed to set PC mode: -3
>
> As there is nothing users can do about the firmware behaving this way,
> demote the warning to debug level.
>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


> ---
>
> Note that a separate change to the cpuidle driver will start logging the
> mode actually used:
>
> 	https://lore.kernel.org/all/20221020115513.93809-1-ulf.hansson@xxxxxxxxxx/
>
> Johan
>
>
>   drivers/firmware/psci/psci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index e7bcfca4159f..462f37fa6a86 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -165,7 +165,7 @@ int psci_set_osi_mode(bool enable)
>   
>   	err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0);
>   	if (err < 0)
> -		pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err);
> +		pr_debug("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err);
>   	return psci_to_linux_errno(err);
>   }
>   

--
With best wishes
Dmitry