Re: [PATCH v1] media: cedrus: Propagate error code from cedrus_h265_skip_bits()

From: Hans Verkuil
Date: Tue Oct 25 2022 - 06:41:48 EST


On 10/25/22 12:36, Dmitry Osipenko wrote:
> On 10/25/22 13:23, Hans Verkuil wrote:
>> On 10/25/22 11:34, Dmitry Osipenko wrote:
>>> On 10/25/22 07:59, Jernej Škrabec wrote:
>>>> Dne ponedeljek, 24. oktober 2022 ob 13:38:36 CEST je Hans Verkuil napisal(a):
>>>>> Hi Dmitry,
>>>>>
>>>>> This patch has a conflict with this patch from Jernej:
>>>>>
>>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20221017194413.11983
>>>>> 01-1-jernej.skrabec@xxxxxxxxx/
>>>>>
>>>>> I decided to take Jernej's patch first. Can you make a v2 that sits on top
>>>>> of that patch?
>>>> I believe you already merged first version of the patch for 6.1. No need for
>>>> this version though, first version already solves main issue.
>>>
>>> That was a followup to the first version.
>>>
>>
>> I have no idea what you are both talking about :-)
>>
>> "I believe you already merged first version of the patch for 6.1" Which patch
>> are you referring to?
>
> This is about [1] that was already merged. This patch implements the
> error propagation that Jernej asked [2] when he reviewed [1].
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=91db7a3fc7fe670cf1770a398a43bb4a1f776bf1
>
> [2] https://lore.kernel.org/lkml/1733932.VLH7GnMWUR@kista/
>
> I'll prepare the v2 if this change is still desired by Jernej.
>

Ah, OK. That was not obvious to me :-)

I'll mark this v1 patch as 'Changes Requested' in patchwork.

Thank you for the explanation!

Regards,

Hans