Re: [PATCH 1/2] cpuidle: dt: Return the correct numbers of parsed idle states

From: Sudeep Holla
Date: Tue Oct 25 2022 - 07:43:18 EST


On Fri, Oct 21, 2022 at 05:10:12PM +0200, Ulf Hansson wrote:
> While we correctly skips to initialize an idle state from a disabled idle
> state node in DT, the returned value from dt_init_idle_driver() don't get
> adjusted accordingly. Instead the number of found idle state nodes are
> returned, while the callers are expecting the number of successfully
> initialized idle states from DT.
>
> This leads to cpuidle drivers unnecessarily continues to initialize their
> idle state specific data. Moreover, in the case when all idle states have
> been disabled in DT, we would end up registering a cpuidle driver, rather
> than relying on the default arch specific idle call.
>

Makes sense.

Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>

--
Regards,
Sudeep