Re: [PATCH] fprobe: Check rethook_alloc() return in rethook initialization

From: Steven Rostedt
Date: Tue Oct 25 2022 - 07:47:51 EST


On Tue, 25 Oct 2022 17:03:46 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> On Tue, 25 Oct 2022 00:12:08 -0300
> Rafael Mendonca <rafaelmendsr@xxxxxxxxx> wrote:
>
> > Check if fp->rethook succeeded to be allocated. Otherwise, if
> > rethook_alloc() fails, then we end up dereferencing a NULL pointer in
> > rethook_add_node().
>
> Good catch!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
>

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Masami, feel free to pull this in.

-- Steve