Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

From: Ulf Hansson
Date: Tue Oct 25 2022 - 09:18:36 EST


On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> >
> > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > Therefore, let's extend the print in the log after a successful probe with
> > this information.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > ---
> > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > index 821984947ed9..c80cf9ddabd8 100644
> > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > if (ret)
> > goto remove_pd;
> >
> > - pr_info("Initialized CPU PM domain topology\n");
> > + pr_info("Initialized CPU PM domain topology using %s mode\n",
> > + use_osi ? "OSI" : "PC");
> > return 0;
> >
> > put_node:
> > --
>
> Am I expected to pick up this one?

Yes, please!

Kind regards
Uffe