Re: [RFC net-next 1/2] dt-bindings: net: dsa: add bindings for GSW Series switches

From: Andrew Lunn
Date: Tue Oct 25 2022 - 11:01:40 EST


> > + - enum:
> > + - mxl,gsw145-mdio
>
> Why "mdio" suffix?

I wondered about that as well. At some point in the future, there
could be an SPI version of this driver, and a UART version. Would they
all use the same compatible, and then context it used to determine the
correct binding? I think the kernel would be happy to do that, but i
don't know if the YAML tools can support that?

> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + mdio {
>
> Hmmm... switch with MDIO is part of MDIO?

Happens a lot. Nothing wrong with this.

Andrew