Re: [PATCH net-next V2] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock

From: Richard Cochran
Date: Tue Oct 25 2022 - 18:03:07 EST


On Tue, Oct 25, 2022 at 02:46:08PM -0700, Richard Cochran wrote:
> On Mon, Oct 24, 2022 at 11:57:23AM -0500, Rob Herring wrote:
> > On Thu, Oct 20, 2022 at 11:41:10PM -0600, Sarath Babu Naidu Gaddam wrote:
> > > There is currently no standard property to pass PTP device index
> > > information to ethernet driver when they are independent.
> > >
> > > ptp-hardware-clock property will contain phandle to PTP clock node.
> > >
> > > Freescale driver currently has this implementation but it will be
> > > good to agree on a generic (optional) property name to link to PTP
> > > phandle to Ethernet node. In future or any current ethernet driver
> > > wants to use this method of reading the PHC index,they can simply use
> > > this generic name and point their own PTP clock node, instead of
> > > creating separate property names in each ethernet driver DT node.
> >
> > Seems like this does the same thing as
> > Documentation/devicetree/bindings/ptp/timestamper.txt.
>
> That is different. It goes from:
>
> MAC -> time stamp generator

actually:
PHY -> time stamp generator

> The proposed binding goes from:
>
> MAC (with built in time stamp generator) -> PTP Hardware Clock (with get/settime etc)
>
>
> Thanks,
> Richard