Re: [PATCH 01/17] staging: vt6655: changed variable names: wFB_Opt0

From: Philipp Hortmann
Date: Tue Oct 25 2022 - 22:46:37 EST


On 10/26/22 01:36, Tanjuate Brunostar wrote:
-static const unsigned short wFB_Opt0[2][5] = {
+static const unsigned short w_fb_opt_0[2][5] = {
{RATE_12M, RATE_18M, RATE_24M, RATE_36M, RATE_48M}, /* fallback_rate0 */
{RATE_12M, RATE_12M, RATE_18M, RATE_24M, RATE_36M}, /* fallback_rate1 */
};

In this driver the variables often start with a "w" for "word", "p" for "pointer", "b" for "bool", "by" for "byte" and even "pv" for "pointer void"...
If possible I would omit those prefixes for the type as they sometimes make the variable names even longer and you need to consider how to break lines.

Bye Philipp