Re: [PATCH net v1] net: wwan: iosm: fix memory leak in ipc_wwan_dellink

[Loic Poulain]

Hi Zhaoping,

On Wed, 26 Oct 2022 at 04:02, zhaoping.shu <zhaoping.shu@xxxxxxxxxxxx> wrote:
>
> From: hw.he <hw.he@xxxxxxxxxxxx>
>
> IOSM driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
>
> This patch sets needs_free_netdev to true when registers
> network device, which makes netdev subsystem call free_netdev()
> automatically after unregister_netdevice().
>
> Signed-off-by: hw.he <hw.he@xxxxxxxxxxxx>
> Signed-off-by: zhaoping.shu <zhaoping.shu@xxxxxxxxxxxx>

Could you please add a corresponding 'fixes' tag.

> ---
>  drivers/net/wwan/iosm/iosm_ipc_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> index 2f1f8b5d5b59..0108d8d01ff2 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> @@ -168,6 +168,7 @@ static void ipc_wwan_setup(struct net_device *iosm_dev)
>         iosm_dev->max_mtu = ETH_MAX_MTU;
>
>         iosm_dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> +       iosm_dev->needs_free_netdev = true;

Look like we have the same problem in mhi_wwan_mbim driver, would you
be able to submit a change for it as well?