Re: [PATCH] block: simplify blksize_bits() implementation

From: Keith Busch
Date: Wed Oct 26 2022 - 12:34:48 EST


On Wed, Oct 26, 2022 at 09:29:21AM -0700, Bart Van Assche wrote:
> On 10/26/22 08:14, Dawei Li wrote:
> > Convert current looping-based implementation into bit operation,
> > which can bring improvement for:
> >
> > 1) bitops is more efficient for its arch-level optimization.
>
> As far as I know blksize_bits() is not used in the hot path so performance
> of this function is not critical.

blksize_bits() is used on every IO going through iomap_dio_bio_iter(),
though the usage there is completely unnecessary and can be removed.