Re: [PATCH v2 2/2] ARM: nspire: Remove unused header file mmio.h

[Fabian Vogt]

Hi,

Am Mittwoch, 26. Oktober 2022, 18:13:02 CEST schrieb Andrew Davis:
> The Nspire boardfile platform drivers have all been converted. None
> of the definitions in this header are used anymore. Remove it.
> 
> While here lets remove all the other unused headers and the file
> name from in the file itself.
> 
> Signed-off-by: Andrew Davis <afd@xxxxxx>

Builds and runs fine here, thanks!

Tested-by: Fabian Vogt <fabian@xxxxxxxxxxxxxx>
Reviewed-by: Fabian Vogt <fabian@xxxxxxxxxxxxxx>

> ---
>  arch/arm/mach-nspire/mmio.h   | 13 -------------
>  arch/arm/mach-nspire/nspire.c | 14 --------------
>  2 files changed, 27 deletions(-)
>  delete mode 100644 arch/arm/mach-nspire/mmio.h
> 
> diff --git a/arch/arm/mach-nspire/mmio.h b/arch/arm/mach-nspire/mmio.h
> deleted file mode 100644
> index 2ce0656139ec..000000000000
> --- a/arch/arm/mach-nspire/mmio.h
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - *	linux/arch/arm/mach-nspire/mmio.h
> - *
> - *	Copyright (C) 2013 Daniel Tang <tangrs@xxxxxxxxxxxx>
> - */
> -
> -#define NSPIRE_PWR_PHYS_BASE		0x900B0000
> -#define NSPIRE_PWR_VIRT_BASE		0xFEEB0000
> -#define NSPIRE_PWR_BUS_DISABLE1		0x18
> -#define NSPIRE_PWR_BUS_DISABLE2		0x20
> -
> -#define NSPIRE_LCD_PHYS_BASE		0xC0000000
> diff --git a/arch/arm/mach-nspire/nspire.c b/arch/arm/mach-nspire/nspire.c
> index 1e13337972dd..2fbfc23237ff 100644
> --- a/arch/arm/mach-nspire/nspire.c
> +++ b/arch/arm/mach-nspire/nspire.c
> @@ -1,23 +1,9 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - *	linux/arch/arm/mach-nspire/nspire.c
> - *
>   *	Copyright (C) 2013 Daniel Tang <tangrs@xxxxxxxxxxxx>
>   */
> -#include <linux/init.h>
> -#include <linux/of_irq.h>
> -#include <linux/of_address.h>
> -#include <linux/of_platform.h>
> -#include <linux/irqchip.h>
> -#include <linux/irqchip/arm-vic.h>
> -#include <linux/clkdev.h>
> -#include <linux/amba/bus.h>
>  
>  #include <asm/mach/arch.h>
> -#include <asm/mach-types.h>
> -#include <asm/mach/map.h>
> -
> -#include "mmio.h"
>  
>  static const char *const nspire_dt_match[] __initconst = {
>  	"ti,nspire",
>