Re: [PATCH next 2/2] dt-bindings: gpio: add entry for hisilicon,gpio-ascend910

From: Rob Herring
Date: Wed Oct 26 2022 - 16:11:25 EST


On Wed, Oct 26, 2022 at 11:42:19AM +0800, Weilong Chen wrote:
> Add the new compatible for HiSilicon gpio controller driver.
>
> Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx>
> ---
> .../gpio/hisilicon,gpio-ascend910.yaml | 54 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml b/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
> new file mode 100644
> index 000000000000..912e4b808cae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/hisilicon,gpio-ascend910.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon common GPIO controller Device Tree Bindings
> +
> +maintainers:
> + - Jay Fang <f.fangjian@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: hisilicon,gpio-ascend910

The normal convention is: vendor,soc-ipblock

> + description:
> + The HiSilicon common GPIO controller can be used for many different
> + types of SoC such as Huawei Ascend AI series chips.
> +
> + reg:
> + description:
> + Address and length of the register set for the device.
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + ngpios:
> + minimum: 1
> + maximum: 32
> +
> +required:
> + - compatible
> + - gpio-controller
> + - reg
> + - interrupts
> + - ngpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + gpio@840d0000 {
> + compatible = "hisilicon,gpio-ascend910";
> + reg = <0x840d0000 0x1000>;
> + ngpios = <0x20>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0x0 33 0x4>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 746becb5fe92..0ec86558cdce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9212,6 +9212,7 @@ HISILICON GPIO DRIVER
> M: Jay Fang <f.fangjian@xxxxxxxxxx>
> L: linux-gpio@xxxxxxxxxxxxxxx
> S: Maintained
> +F: Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
> F: drivers/gpio/gpio-hisi.c
>
> HISILICON HIGH PERFORMANCE RSA ENGINE DRIVER (HPRE)
> --
> 2.31.GIT
>
>