Re: [PATCH v9 8/9] mfd: Add Ampere's Altra SMpro MFD driver

[Quan Nguyen]

On 24/10/2022 19:39, Lee Jones wrote:
> On Thu, 29 Sep 2022, Quan Nguyen wrote:
>
> > Adds Multi-function devices driver for SMpro co-processor found on the
> > Mt.Jade hardware reference platform with Ampere's Altra processor family.
> >
> > Signed-off-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v9:
> >    + Rename smpro-mfd.c to smpro-core.c                   [Lee Jones]
> >    + Fix include files in alphabetical order              [Lee Jones]
> >    + Add defines to avoid using magic numbers             [Lee Jones]
> >    + Return -EINVAL if device does not match              [Lee Jones]
> >    + Remove unneccessary comment                          [Lee Jones]
> >    + Refactor error path handling in smpro_core_read/write()   [Quan]
> >
> > Changes in v8:
> >    + None
> >
> > Changes in v7:
> >    + Smpro-mfd now significant changes in compare with simple-mfd-i2c
> >      driver, remove the copyright note about simple-mfd-i2c    [Quan]
> >    + Install bus->read/write()  to handle multiple types of bus
> >      access.                                                   [Quan]
> >    + Update license to MODULE_LICENSE("GPL")                   [Quan]
> >    + Add others minor refactor the code                        [Quan]
> >
> > Changes in v6:
> >    + Update license part to reflect that this driver is clone from
> >    simple-mfd-i2c driver [Quan]
> >
> > Changes in v5:
> >    + Dropped the use of simple-mfd-i2c driver [Quan]
> >    + Introduced drivers/mfd/smpro-mfd.c driver to instantiate
> >    sub-devices. This is to avoid DT nodes without resource issue [Quan]
> >    + Revised commit message [Quan]
> >
> > Changes in v4:
> >    + Add "depends on I2C" to fix build issue found by kernel test
> >    robot [Guenter]
> >
> > Changes in v3:
> >    + None
> >
> > Changes in v2:
> >    + Used 'struct of_device_id's .data attribute [Lee Jones]
> >
> >   drivers/mfd/Kconfig      |  12 ++++
> >   drivers/mfd/Makefile     |   1 +
> >   drivers/mfd/smpro-core.c | 138 +++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 151 insertions(+)
> >   create mode 100644 drivers/mfd/smpro-core.c
>
> Applied, thanks.

Thank you for picking the patch.
- Quan