Re: [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

From: Dave Airlie
Date: Thu Oct 27 2022 - 01:12:59 EST


On Thu, 27 Oct 2022 at 13:26, Zheng Hacker <hackerzheng666@xxxxxxxxx> wrote:
>
> Dave Airlie <airlied@xxxxxxxxx> 于2022年10月27日周四 08:01写道:
> >
> > On Fri, 7 Oct 2022 at 11:38, Zheng Wang <zyytlz.wz@xxxxxxx> wrote:
> > >
> > > If intel_gvt_dma_map_guest_page failed, it will call
> > > ppgtt_invalidate_spt, which will finally free the spt.
> > > But the caller does not notice that, it will free spt again in error path.
> > >
> > > Fix this by spliting invalidate and free in ppgtt_invalidate_spt.
> > > Only free spt when in good case.
> > >
> > > Reported-by: Zheng Wang <hackerzheng666@xxxxxxxxx>
> > > Signed-off-by: Zheng Wang <zyytlz.wz@xxxxxxx>
> >
> > Has this landed in a tree yet, since it's a possible CVE, might be
> > good to merge it somewhere.
> >
> > Dave.
> >
>
> Hi Dave,
>
> This patched hasn't been merged yet. Could you please help with this?

I'll add some more people who can probably look at it.

Dave.