Re: [PATCH RFC v3 03/22] scsi: core: Implement reserved command handling

From: John Garry
Date: Thu Oct 27 2022 - 05:12:47 EST




device_initialize(&shost->shost_gendev);
dev_set_name(&shost->shost_gendev, "host%d", shost->host_no);
shost->shost_gendev.bus = &scsi_bus_type;
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 39d4fd124375..a8c4e7c037ae 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1978,6 +1978,8 @@ int scsi_mq_setup_tags(struct Scsi_Host *shost)
tag_set->nr_hw_queues = shost->nr_hw_queues ? : 1;
tag_set->nr_maps = shost->nr_maps ? : 1;
tag_set->queue_depth = shost->can_queue;
+ tag_set->reserved_tags = shost->nr_reserved_cmds;
+
Why the blank line ?


I don't think that it is required, I can remedy.

tag_set->cmd_size = cmd_size;

Thanks,
John