Re: [PATCH 0/2] Fix MSR access errors during kexec in root partition

From: Anirudh Rayabharam
Date: Thu Oct 27 2022 - 06:03:48 EST


On Wed, Oct 26, 2022 at 02:57:58PM +0000, Michael Kelley (LINUX) wrote:
> From: Anirudh Rayabharam <anrayabh@xxxxxxxxxxxxxxxxxxx> Sent: Wednesday, October 26, 2022 6:47 AM
> >
> > Fixes a couple of MSR access errors seen during kexec in root partition
> > and opportunistically introduces a data structure for the reference TSC
> > MSR in order to simplify the code that updates that MSR.
> >
> > Anirudh Rayabharam (2):
> > x86/hyperv: fix invalid writes to MSRs during root partition kexec
> > clocksource/drivers/hyperv: add data structure for reference TSC MSR
>
> Could these two patches be sequenced in the opposite order, to avoid the
> need to change the TSC code in hyperv_cleanup() twice? The new
> data structure for the Reference TSC MSR and clocksource driver changes
> would be in the first patch. Then the second patch would update
> hyperv_cleanup() and could use the new data structure.

I just sent a new version with the ordering you suggested.

Thanks,
Anirudh.

>
> Michael
>
> >
> > arch/x86/hyperv/hv_init.c | 11 +++++++----
> > drivers/clocksource/hyperv_timer.c | 28 ++++++++++++++--------------
> > include/asm-generic/hyperv-tlfs.h | 9 +++++++++
> > 3 files changed, 30 insertions(+), 18 deletions(-)
> >
> > --
> > 2.34.1